|
sylpheed:24278
From: Godwin Stewart <gstewart@xxxxxxxxxx> On Mon, 7 Mar 2005 20:33:28 +0900, Hiroyuki Yamamoto <hiro-y@xxxxxxxxxx> wrote: > In the current code, if charset is NULL and passed to > textview_write_line(), eventually conv_iconv_strdup() is called with > (inbuf, NULL, NULL), and it does locale-encoding-to-UTF-8 conversion. > Can you retry with plain 1.9.5? That's obviously what you were working on just before you asked me to generate the patch against trunk because the message in question is displayed correctly now, with no particular action on my part :) No need for my fallback codeset patch any more. > Force charset setting is for broken messages, which specify wrong > charsets (different from actually used one). Fallback charset can't > handle such messages. True, but I have yet to see one such malformed message (maybe it's a whole new problem in .jp with several codesets for the same language), whereas messages with no character set specification at all are far from rare. However, now that sylpheed uses locale-encoding by default, the point has become rather academic :) -- G. Stewart - gstewart@xxxxxxxxxx The three "R"s of Microsoft support: Retry, Reboot, Reinstall. Attachment@ 24233 2005-03-04 00:01 [gstewart@xxxxxxxxxx ] [PATCH] fallback character set 24252 2005-03-04 19:58 |-[daichi.k@xxxxxxxxxx ] @ 24253 2005-03-04 20:26 | `-[gstewart@xxxxxxxxxx ] @ 24254 2005-03-04 20:30 | |-[gstewart@xxxxxxxxxx ] 24255 2005-03-04 20:40 | `-[daichi.k@xxxxxxxxxx ] 24256 2005-03-04 20:48 |-[hiro-y@xxxxxxxxxx ] @ 24257 2005-03-04 21:10 | |-[gstewart@xxxxxxxxxx ] @ 24258 2005-03-04 21:37 | `-[gstewart@xxxxxxxxxx ] 24272 2005-03-07 16:18 `-[hiro-y@xxxxxxxxxx ] @ 24275 2005-03-07 19:15 `-[gstewart@xxxxxxxxxx ] 24276 2005-03-07 19:53 |-[daichi.k@xxxxxxxxxx ] 24277 2005-03-07 20:33 `-[hiro-y@xxxxxxxxxx ] -> @ 24278 2005-03-07 21:08 `-[gstewart@xxxxxxxxxx ] |