[prev][next][list][thread]

sylpheed:24275

From: Godwin Stewart <gstewart@xxxxxxxxxx>
Date: Mon, 7 Mar 2005 11:15:06 +0100
Subject: [sylpheed:24275] Re: [PATCH] fallback character set

On Mon, 7 Mar 2005 16:18:52 +0900, Hiroyuki Yamamoto <hiro-y@xxxxxxxxxx>
wrote:

> Since the current code uses locale encoding as a default

Actually, it doesn't. Or at least not here, it doesn't. If it did, this
(malformed) message http://www.bonivet.net/misc/example_mail.txt which does
use ISO-8859-15 characters (and my locale is ISO-8859-15) would not be
rendered like this: http://www.bonivet.net/misc/sylpheed_msg_view.png, but
like this: http://www.bonivet.net/misc/sylpheed_msg_view_ok.png.

For it to use locale encoding by default, it would need things like this in
procmime.c and textview.c (from memory it's those 2 files):

if ( !prefs_common.force_charset && !mimeinfo->charset )
	charset = conv_get_locale_charset_str();

> and forcing encoding is available, I think there's not much problem

It is, yes. But if another mail turns up correctly encoded in a different
codeset than the one the user just forced, it will get rendered with the
wrong codeset meaning that the user has to turn the "force charset" feature
off again to view the new mail correctly.

The "fallback codeset" has the advantage of only applying to mails that
don't specify which codeset they use and therefore not interfering with
correctly encoded mails, which is why I wrote it in the first place.

Maybe I could be so bold as to suggest using the fallback codeset instead
of the force codeset, rather than in addition to the force codeset? Its
behaviour is, IMHO, preferable in that it leaves correctly encoded stuff
alone.

-- 
G. Stewart - gstewart@xxxxxxxxxx

QOTD - "It was so cold last Winter that I even saw a lawyer
with his hands in his own pockets"




[prev][next][list][thread]

   @ 24233 2005-03-04 00:01 [gstewart@xxxxxxxxxx ] [PATCH] fallback character set          
     24252 2005-03-04 19:58 |-[daichi.k@xxxxxxxxxx ]                                       
   @ 24253 2005-03-04 20:26 | `-[gstewart@xxxxxxxxxx ]                                     
   @ 24254 2005-03-04 20:30 |   |-[gstewart@xxxxxxxxxx ]                                   
     24255 2005-03-04 20:40 |   `-[daichi.k@xxxxxxxxxx ]                                   
     24256 2005-03-04 20:48 |-[hiro-y@xxxxxxxxxx   ]                                       
   @ 24257 2005-03-04 21:10 | |-[gstewart@xxxxxxxxxx ]                                     
   @ 24258 2005-03-04 21:37 | `-[gstewart@xxxxxxxxxx ]                                     
     24272 2005-03-07 16:18 `-[hiro-y@xxxxxxxxxx   ]                                       
-> @ 24275 2005-03-07 19:15   `-[gstewart@xxxxxxxxxx ]                                     
     24276 2005-03-07 19:53     |-[daichi.k@xxxxxxxxxx ]                                   
     24277 2005-03-07 20:33     `-[hiro-y@xxxxxxxxxx   ]                                   
   @ 24278 2005-03-07 21:08       `-[gstewart@xxxxxxxxxx ]